fix: build with Xcode 10 may fail for missing plugins...xcconfig file #3913
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
reviewed
Sep 19, 2018
lib/services/ios-project-service.ts
Outdated
| @@ -778,7 +778,7 @@ We will now place an empty obsolete compatability white screen LauncScreen.xib f | |||
| this.$fs.deleteDirectory(this.getAppResourcesDestinationDirectoryPath(projectData)); | |||
| } | |||
|
|
|||
| public async processConfigurationFilesFromAppResources(release: boolean, projectData: IProjectData): Promise<void> { | |||
| public async processConfigurationFilesFromAppResources(release: boolean, projectData: IProjectData): Promise<void> { | |||
|
test |
|
@rosen-vladimirov, it looks like the fix works according to our CI tests. Yet we still need time to setup the PR scripts related to CLI package hook. Also CLI-e2e hook is the old one and should be ignored for now. |
In the iOS Project template we have include for plugins-debug.xcconfig (or plugins-release.xcconfig when building in release mode). CLI should produce such file, but it does not do it when the project does not have build.xcconfig in its App_Resources and neither of the plugins have such file. With previous Xcode versions, this case was leading to warnings in the output, however they are errors now and the build fails. Fix this by adding an empty file in such case.
rosen-vladimirov
force-pushed
the
vladimirov/fix-xcode10-plugins-xcconfig
branch
from
8ab5aae to
bfd5b3f
Compare
Fatme
approved these changes
Sep 20, 2018
rosen-vladimirov
deleted the
vladimirov/fix-xcode10-plugins-xcconfig
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the iOS Project template we have include for plugins-debug.xcconfig (or plugins-release.xcconfig when building in release mode). CLI should produce such file, but it does not do it when the project does not have build.xcconfig in its App_Resources and neither of the plugins have such file. With previous Xcode versions, this case was leading to warnings in the output, however they are errors now and the build fails.
Fix this by adding an empty file in such case.
PR Checklist
What is the current behavior?
Build fails for iOS in case the following circumstances are fulfilled:
App_Resources/iOS/build.xcconfig<plugin dir>/platforms/ios/build.xcconfigWhat is the new behavior?
The application can be build in case the mentioned circumstances are fulfilled.
Fixes #3912